Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update POM files #4492

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Update POM files #4492

merged 1 commit into from
Jun 28, 2023

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jun 27, 2023

The POM files have been modified to use the latest dependencies. The dependencies have been moved into the modules that actually need them. The maven-surefire-plugin has been added to run JUnit 5 tests properly. A new POM file has also been added for EST.

The RPM spec and Azure pipelines have been updated to use the same dependencies as in the POM files.

@edewata edewata added the WIP Work In Progress label Jun 27, 2023
@edewata
Copy link
Contributor Author

edewata commented Jun 27, 2023

Not ready yet, there's a failure in Azure pipelines.

The POM files have been modified to use the latest dependencies.
The dependencies have been moved into the modules that actually
need them. The maven-surefire-plugin has been added to run JUnit
5 tests properly. A new POM file has also been added for EST.

The RPM spec and Azure pipelines have been updated to use the
same dependencies as in the POM files.
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@edewata edewata removed the WIP Work In Progress label Jun 27, 2023
@edewata
Copy link
Contributor Author

edewata commented Jun 27, 2023

It's ready now, all tests passed.

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ckelleyRH ckelleyRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Jun 28, 2023

@fmarco76 @ckelleyRH Thanks!

@edewata edewata merged commit e858268 into dogtagpki:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants